Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - New view: merged all stats from all libraries #3335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Vito0912
Copy link
Contributor

Based on #3330

This PR introduces a new page titled "All Libraries Stats," which mirrors the existing "Library Stats" view but combines data from all libraries.

We might want to consider refactoring the design since this results in some duplicated code. While there are slight modifications, primarily in the computed section, much of the functionality remains the same.

Image:
image

@faush01
Copy link
Contributor

faush01 commented Aug 26, 2024

cant this just be a toggle on the stats page to include all libraries?
having multiple pages for stats like this may be confusing.

@Vito0912
Copy link
Contributor Author

cant this just be a toggle on the stats page to include all libraries?
having multiple pages for stats like this may be confusing.

I wouldn't recommend making this change. Although the design may appear similar, the "library stats" are actually located on the left-hand side of the current page, not in the settings, since they pertain specifically to this library. Having the label in the settings is, in my opinion, incorrect (and frustrating when navigating through pages and getting redirected), since it was recently moved.

Since "all libraries stats" are independent of the selected libraries, I suggest removing the incorrect button from the settings instead and having a button for all stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants